Add more test cases and improve utils.py functions#22
Conversation
- Improved `guess_classname` to support classes without parentheses, classes with arbitrary base classes, and complex class definitions. - Simplified `camel_to_snake` by removing redundant regex substitution. - Added comprehensive test cases for both functions in `utils_test.py`. - Updated existing tests to match improved functionality. Co-authored-by: digitalex <23829+digitalex@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
I have added 8 new test cases to
utils_test.pycovering various edge cases forguess_classnameandcamel_to_snake.The new tests revealed that
guess_classnamewas too restrictive, only supporting classes inheriting fromABCorobjectand requiring parentheses. I fixed this by updating the regex to be more inclusive of standard Python class definitions.I also simplified
camel_to_snakeby removing a redundant code line and verified that all tests (old and new) pass successfully.PR created automatically by Jules for task 6845842104423672262 started by @digitalex