Skip to content

returns nil when url type setting is empty string #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggpasqualino merged 2 commits into from
Aug 29, 2017
Merged

returns nil when url type setting is empty string #200

ggpasqualino merged 2 commits into from
Aug 29, 2017

Conversation

@ghatighorias
Copy link
Contributor

@ghatighorias ghatighorias commented Aug 28, 2017

this modification is making frontend part more neat

@ghatighorias
returns nil when url type setting is empty string
1faef57 
this modification is making frontend part more neat
@coveralls
Copy link

coveralls commented Aug 28, 2017

Coverage Status

Coverage remained the same at 86.957% when pulling 1faef57 on ghatighorias/nil_return_for_empty_url_setting into e84bce6 on master.

rhnonose
rhnonose approved these changes Aug 28, 2017
View reviewed changes
Copy link
Contributor

@rhnonose rhnonose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#198 is using the empty string return value

@coveralls
Copy link

coveralls commented Aug 29, 2017

Coverage Status

Changes Unknown when pulling 1f8d314 on ghatighorias/nil_return_for_empty_url_setting into ** on master**.

@ggpasqualino ggpasqualino merged commit b5463c1 into master Aug 29, 2017
@ggpasqualino ggpasqualino deleted the ghatighorias/nil_return_for_empty_url_setting branch August 29, 2017 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggpasqualino ggpasqualino Awaiting requested review from ggpasqualino

2 more reviewers

@rhnonose rhnonose rhnonose approved these changes

@laszlokardinal laszlokardinal laszlokardinal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ghatighorias @coveralls @rhnonose @laszlokardinal @ggpasqualino