fix: post-gen patch for embeddings input serialization#153
Merged
SSharma-10 merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
Kiota generates writeCollectionOfObjectValues for Embeddings_request.input
(a string | string[] union), which wraps each string in {} braces producing
malformed JSON. Add post-gen step 7 to replace it with
writeCollectionOfPrimitiveValues, which correctly serializes string arrays.
Made-with: Cursor
SSharma-10
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writeCollectionOfObjectValuesforEmbeddings_request.input(astring | string[]union type), which wraps each plain string in{}braces, producing malformed JSON like[{"hello world"}]instead of["hello world"]postgen-inference.mjsthat automatically replaces the broken call withwriteCollectionOfPrimitiveValuesafter everymake generateserializationFixesarray is extensible for any similar Kiota union-type bugs in the futureTest plan
make generateand verifysrc/dots/models/index.tsuseswriteCollectionOfPrimitiveValuesforembeddings_request.input/v1/embeddingswith an array input and verify the request succeedsMade with Cursor