Add spec changes for subdomain routing on App Platform#1005
Merged
loosla merged 2 commits intodigitalocean:mainfrom Apr 24, 2025
Merged
Add spec changes for subdomain routing on App Platform#1005loosla merged 2 commits intodigitalocean:mainfrom
loosla merged 2 commits intodigitalocean:mainfrom
Conversation
loosla
reviewed
Apr 24, 2025
Comment on lines
2
to
4
| oneOf: | ||
| - required: [prefix] | ||
| - required: [exact] |
Contributor
There was a problem hiding this comment.
Suggested change
| oneOf: | |
| - required: [prefix] | |
| - required: [exact] |
Let’s remove it, as it seems a bit confusing. Instead, include this information directly in the description: " Choose either path or authority — not both."
Member
Author
There was a problem hiding this comment.
Actually, I goofed here — both prefix and authority can be used at the same time. Not sure why I thought oneOf made sense. Updated accordingly.
loosla
reviewed
Apr 24, 2025
loosla
reviewed
Apr 24, 2025
specification/resources/apps/models/app_ingress_spec_rule_string_match_exact.yml
Outdated
Show resolved
Hide resolved
loosla
reviewed
Apr 24, 2025
specification/resources/apps/models/app_ingress_spec_rule_string_match_exact.yml
Outdated
Show resolved
Hide resolved
Contributor
|
@ZachEddy Awesome work 🚀 Ready to approve once a few final updates are made. |
- Wrap example.com in quotes - Fix indentation for exact match (and prefix for consistency) - Remove oneOf because it's not applicable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the OpenAPI spec with app spec changes for subdomain routing.