APPS-5889: add docs for liveness_health_check#1024
Merged
danaelhe merged 5 commits intodigitalocean:mainfrom May 9, 2025
Merged
APPS-5889: add docs for liveness_health_check#1024danaelhe merged 5 commits intodigitalocean:mainfrom
danaelhe merged 5 commits intodigitalocean:mainfrom
Conversation
Member
There was a problem hiding this comment.
This looks nearly identical to the existing spec used with health_check (except for the additional info on min and max values):
Can we reduce duplication by sharing it between them or do we expect that they will diverge over time?
Contributor
Author
There was a problem hiding this comment.
one of them will be deprecated in favor of this one.
danaelhe
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.