Skip to content

Add POST body for registry start GC#1028

Merged
danaelhe merged 6 commits intodigitalocean:mainfrom
nayanjd-do:ndas/document-start-gc-body
May 30, 2025
Merged

Add POST body for registry start GC#1028
danaelhe merged 6 commits intodigitalocean:mainfrom
nayanjd-do:ndas/document-start-gc-body

Conversation

@nayanjd-do
Copy link
Copy Markdown
Contributor

@nayanjd-do nayanjd-do commented May 16, 2025

This PR adds optional body for POST request to start registry garbage collection -> https://docs.digitalocean.com/reference/api/digitalocean/#tag/Container-Registry/operation/registry_run_garbageCollection

@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented May 16, 2025

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
16975705 Triggered Generic High Entropy Secret 8534c30 specification/resources/partner_network_connect/examples/curl/partner_attachment_create.yml View secret
16903018 Triggered Generic High Entropy Secret 6981f65 specification/resources/partner_network_connect/examples/python/partner_attachment_bgp_auth_key_get.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Comment thread specification/resources/registry/registry_run_garbageCollection.yml
Copy link
Copy Markdown
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@danaelhe danaelhe merged commit 8e1310c into digitalocean:main May 30, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants