openapi spec for advanced_pg + advanced_mysql#1167
openapi spec for advanced_pg + advanced_mysql#1167DO-rrao merged 7 commits intodigitalocean:mainfrom
Conversation
DO-rrao
left a comment
DO-rrao
left a comment
There was a problem hiding this comment.
Automated Review Summary
Live API validation (GET /v2/databases/options) revealed spec-vs-production mismatches in the advanced_mysql version string and advanced_pg version_availability lifecycle dates. See inline comments for details.
Overall the structural changes (enum additions, model refs, options schema, layouts, sizes) are correctly wired and CI is green.
| @@ -588,3 +789,21 @@ content: | |||
| end_of_availability: null | |||
There was a problem hiding this comment.
Critical: advanced_pg version_availability has hardcoded EOL/EOA dates (e.g. eol: "2028-11-09T00:00:00Z" for v16), but the live API returns null for all three versions. Fabricating lifecycle dates that the API doesn't return will mislead consumers building version deprecation logic. These should be set to null to match production, or confirmed with the backend team if these dates are intentionally planned but not yet surfaced by the API.
There was a problem hiding this comment.
The EOL dates are correct but not returned in the API properly (will be fixed). However, they reflect the open-source EOL dates for those version of PG and are accurate
|
|
||
| PostgreSQL and MySQL Advanced Edition clusters can be provisioned by setting `engine` to | ||
| `advanced_pg` or `advanced_mysql`. Advanced Edition clusters are currently in public | ||
| preview. `advanced_pg` supports 1-, 2-, and 3-node deployments. `advanced_mysql` only |
There was a problem hiding this comment.
Warning: The description mentions Advanced Edition is "in public preview" but doesn't explain what it offers over standard pg/mysql. A brief note on the key differences (e.g. features, performance characteristics) or a link to relevant documentation would help users decide which engine to provision.
3 participants
Add support for
advanced_pgandadvanced_mysqleditions in the Managed Databases API spec