gen-ai: remove deprecated save_as_preset field#1197
Merged
anup-deka merged 1 commit intoJul 3, 2026
Merged
Conversation
Removes the legacy save_as_preset boolean from apiCreateModelEvaluationRunInputPublic; superseded by preset_save_sections. Mirrors the removal in the gen-ai proto (cthulhu). Co-authored-by: Cursor <cursoragent@cursor.com>
anup-deka
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
save_as_presetboolean property fromapiCreateModelEvaluationRunInputPublicinspecification/resources/gen-ai/definitions.yml.preset_save_sections, which allows selecting individual preset sections to save instead of an all-or-nothing boolean.save_as_presetfield from the gen-ai API's proto definition.Test plan
make bundlesucceeds with no new warnings/errors introduced by this change.save_as_presetremain in the spec.Made with Cursor