Closed
Conversation
lee-aaron
force-pushed
the
alee/keys-api
branch
2 times, most recently
from
2749a98 to
926ae10
Compare
andrewsomething
requested changes
Jan 7, 2025
Member
andrewsomething
left a comment
andrewsomething
left a comment
There was a problem hiding this comment.
Looking good! I did leave a few comments in-line. Let me know if you have any questions about them.
lee-aaron
force-pushed
the
alee/keys-api
branch
from
926ae10 to
b6b3fd4
Compare
lee-aaron
force-pushed
the
alee/keys-api
branch
from
c018d9c to
982efa0
Compare
lee-aaron
force-pushed
the
alee/keys-api
branch
from
a841e85 to
f7e4198
Compare
andrewsomething
requested changes
Jan 8, 2025
Member
andrewsomething
left a comment
andrewsomething
left a comment
There was a problem hiding this comment.
Looks great! 🙌 A couple tiny changes needed for the update response bodies.
Co-authored-by: Andrew Starr-Bochicchio <andrewsomething@users.noreply.github.com>
lee-aaron
force-pushed
the
alee/keys-api
branch
from
c2cbd59 to
79b0cb6
Compare
dbrian57
reviewed
Feb 20, 2025
dbrian57
suggested changes
Feb 20, 2025
lee-aaron
force-pushed
the
alee/keys-api
branch
3 times, most recently
from
7bcedff to
4175ea0
Compare
Co-authored-by: Dan Brian <daniel.brian@gmail.com>
lee-aaron
force-pushed
the
alee/keys-api
branch
from
4175ea0 to
daaf925
Compare
lee-aaron
force-pushed
the
alee/keys-api
branch
2 times, most recently
from
6054cfe to
8fb926e
Compare
dbrian57
previously approved these changes
Mar 12, 2025
lee-aaron
force-pushed
the
alee/keys-api
branch
2 times, most recently
from
d07afb7 to
9ed48ba
Compare
lee-aaron
force-pushed
the
alee/keys-api
branch
from
9ed48ba to
0d3cea1
Compare
andrewsomething
requested changes
Mar 19, 2025
| @@ -0,0 +1,75 @@ | |||
| operationId: spacesKey_create | |||
|
|
|||
| summary: "[Beta] Create a New Spaces Access Key" | |||
Member
There was a problem hiding this comment.
Suggested change
| summary: "[Beta] Create a New Spaces Access Key" | |
| summary: "Create a New Spaces Access Key" |
This is now being released directly to GA. We should remove the beta tags here and elsewhere.
| @@ -0,0 +1,40 @@ | |||
| operationId: spacesKey_delete | |||
|
|
|||
| summary: "[Beta] Delete a Spaces Access Key" | |||
Member
There was a problem hiding this comment.
Suggested change
| summary: "[Beta] Delete a Spaces Access Key" | |
| summary: "Delete a Spaces Access Key" |
| @@ -0,0 +1,40 @@ | |||
| operationId: spacesKey_delete | |||
|
|
|||
| summary: "[Beta] Get a Spaces Access Key" | |||
Member
There was a problem hiding this comment.
Suggested change
| summary: "[Beta] Get a Spaces Access Key" | |
| summary: "Get a Spaces Access Key" |
| @@ -0,0 +1,41 @@ | |||
| operationId: spacesKey_list | |||
|
|
|||
| summary: "[Beta] List Spaces Access Keys" | |||
Member
There was a problem hiding this comment.
Suggested change
| summary: "[Beta] List Spaces Access Keys" | |
| summary: "List Spaces Access Keys" |
| @@ -0,0 +1,50 @@ | |||
| operationId: spacesKey_patch | |||
|
|
|||
| summary: "[Beta] Update Spaces Access Keys" | |||
Member
There was a problem hiding this comment.
Suggested change
| summary: "[Beta] Update Spaces Access Keys" | |
| summary: "Update Spaces Access Keys" |
| @@ -0,0 +1,40 @@ | |||
| operationId: spacesKey_delete | |||
Member
There was a problem hiding this comment.
Suggested change
| operationId: spacesKey_delete | |
| operationId: spacesKey_get |
The operation name must be unique and should reflect the purpose of the endpoint. It is used to generate client method names. This is the cause of the lint error in CI.
This was referenced Mar 20, 2025
Member
|
Closing in favor of #993 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OBJECT-6022
This adds information about the Spaces Key API to the OpenAPI spec.
I can add a
[Beta]tag somewhere if needed as users would need to be on the flipper to access this!