Skip to content

Conversation

@opoliarush
Copy link
Contributor

@opoliarush opoliarush commented Oct 8, 2024

kshmidt-digma
kshmidt-digma previously approved these changes Oct 8, 2024
Comment on lines 22 to 33
items={[
...endpoints.map((x) => ({
id: x.spanCodeObjectId,
customContent: (
<s.MenuItem onClick={() => handleMenuItemClick(x)}>
<HTTPClientIcon size={12} color="currentColor" />
<span>{x.displayName}</span>
</s.MenuItem>
),
disabled: false
}))
]}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to spread here?

Suggested change
items={[
...endpoints.map((x) => ({
id: x.spanCodeObjectId,
customContent: (
<s.MenuItem onClick={() => handleMenuItemClick(x)}>
<HTTPClientIcon size={12} color="currentColor" />
<span>{x.displayName}</span>
</s.MenuItem>
),
disabled: false
}))
]}
items={endpoints.map((x) => ({
id: x.spanCodeObjectId,
customContent: (
<s.MenuItem onClick={() => handleMenuItemClick(x)}>
<HTTPClientIcon size={12} color="currentColor" />
<span>{x.displayName}</span>
</s.MenuItem>
),
disabled: false
}))}

@opoliarush opoliarush merged commit cbd1c0b into main Oct 8, 2024
1 check passed
@opoliarush opoliarush deleted the linked-endpoints branch October 8, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants