Skip to content

Restrict sorting in Analytics tab #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Restrict sorting in Analytics tab #689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/components/Insights/InsightsCatalog/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,15 @@ export const InsightsCatalog = (props: InsightsCatalogProps) => {
setSorting(val);
}}
options={[
{
value: SORTING_CRITERION.CRITICAL_INSIGHTS,
label: "Critical insights",
defaultOrder: SORTING_ORDER.DESC
},
...(defaultQuery.insightViewType === "Issues"
? [
{
value: SORTING_CRITERION.CRITICAL_INSIGHTS,
label: "Critical insights",
defaultOrder: SORTING_ORDER.DESC
}
]
: []),
{
value: SORTING_CRITERION.LATEST,
label: "Latest",
Expand Down
10 changes: 5 additions & 5 deletions src/components/Insights/common/InsightCard/Select/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@ export const Select = (props: SelectProps) => {
>
{selectedOption ? (
<Tooltip title={selectedOption.label}>
{selectedOption.customContent ? (
<>{selectedOption.customContent}</>
) : (
<s.SelectedValue>{selectedOption.label}</s.SelectedValue>
)}
<s.SelectedValue>
{selectedOption.customContent
? selectedOption.customContent
: selectedOption.label}
</s.SelectedValue>
</Tooltip>
) : (
props.placeholder
Expand Down
2 changes: 1 addition & 1 deletion src/components/Insights/common/InsightCard/Select/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export const SelectBar = styled.div<SelectBarProps>`
}
`;

export const SelectedValue = styled.span`
export const SelectedValue = styled.div`
text-overflow: ellipsis;
white-space: nowrap;
overflow: hidden;
Expand Down