Feature/create new env flow #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshmidt-digma
requested changes
Apr 1, 2024
src/components/RecentActivity/CreateEnvironmentWizard/CreateEnvironmentPanel/Tab/index.tsx
Outdated
Show resolved
Hide resolved
src/components/RecentActivity/CreateEnvironmentWizard/EnvironmentCreated/index.tsx
Outdated
Show resolved
Hide resolved
src/components/RecentActivity/CreateEnvironmentWizard/EnvironmentNameStep/index.tsx
Outdated
Show resolved
Hide resolved
src/components/RecentActivity/CreateEnvironmentWizard/EnvironmentNameStep/index.tsx
Outdated
Show resolved
Hide resolved
src/actions.ts
Outdated
Comment on lines
49
to
50
| REGISTRATION: "REGISTRATION", | ||
| SET_REGISTRATION_RESULT: "SET_REGISTRATION_RESULT", |
Collaborator
There was a problem hiding this comment.
As we already have GLOBAL/REGISTER, consider some other name for the old message: POSTHOG_REGISTER?
Suggested change
| REGISTRATION: "REGISTRATION", | |
| SET_REGISTRATION_RESULT: "SET_REGISTRATION_RESULT", | |
| REGISTER: "REGISTRER", | |
| SET_REGISTRER_RESULT: "SET_REGISTER_RESULT", |
| import { KeyboardEvent, useEffect } from "react"; | ||
| import { Controller, useForm } from "react-hook-form"; | ||
| import { sendUserActionTrackingEvent } from "../../../../utils/actions/sendUserActionTrackingEvent"; | ||
| import { TextField } from "../../../common/RegistrationDialog/TextField"; // TODO: change when new env will be merged |
| }; | ||
|
|
||
| const handleLogoutClick = () => { | ||
| window.sendMessageToDigma({ |
| onClose: () => void; | ||
| } | ||
|
|
||
| export interface MenuItem { |
Collaborator
There was a problem hiding this comment.
Please reuse type from MenuListProps of Navigation/common/MenuList component
|
|
||
| // More on writing stories with args: https://storybook.js.org/docs/react/writing-stories/args | ||
| export const Default: Story = { | ||
| args: {} |
Collaborator
There was a problem hiding this comment.
Suggested change
| args: {} |
| @@ -379,7 +177,7 @@ export const RecentActivity = (props: RecentActivityProps) => { | |||
|
|
|||
| const handleConfirmEnvironmentDeletion = () => { | |||
| window.sendMessageToDigma({ | |||
| action: actions.DELETE_ENVIRONMENT, | |||
| action: actions.DELETE_ENVIRONMENT_V2, | |||
Collaborator
There was a problem hiding this comment.
Check if we need v2?
| OPEN_REGISTRATION_DIALOG: "OPEN_REGISTRATION_DIALOG", | ||
| DELETE_ENVIRONMENT_V2: "DELETE_ENVIRONMENT_V2", | ||
| CREATE_ENVIRONMENT: "CREATE_ENVIRONMENT", | ||
| ENVIRONMENT_CREATED: "ENVIRONMENT_CREATED" |
Collaborator
There was a problem hiding this comment.
Suggested change
| ENVIRONMENT_CREATED: "ENVIRONMENT_CREATED" | |
| SET_CREATE_ENVIRONMENT_RESULT: "SET_CREATE_ENVIRONMENT_RESULT" |
src/components/RecentActivity/WelcomeScreen/WelcomeScreen.stories.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Kyrylo Shmidt <119138536+kshmidt-digma@users.noreply.github.com>
…into fix-validation
Fix validation
Fix validation error
…a-ai/digma-ui into feature/create-new-env-flow
Fix password validation
* Fix documentation and environment instructions
…a-ai/digma-ui into feature/create-new-env-flow
Show registration dialog
* Fix documentation and environment instructions * Update styles Redirect to sign in after sign up Hide Close button in Environment instructions after its creation
kshmidt-digma
previously approved these changes
Apr 19, 2024
kshmidt-digma
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impl #747