Skip to content

Make spans without code locations clickable #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2023
Merged

Make spans without code locations clickable #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
def9e45
Make spans without code locations clickable
kshmidt-digma May 15, 2023
265a88c
Make spans clickable only if they have insights
kshmidt-digma May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import LabeledList from '../../../common/LabeledList';
import { actions } from '../../../../api/digma/actions';
import { dispatcher } from '../../../../api/digma/dispatcher';
import { state as globalState } from '../../../../api/digma/state';
import { SetSpansDataPayload } from '../../../../api/digma/types';
import { ISpanInsight, SetSpansDataPayload } from '../../../../api/digma/types';
import { getInsightTypeInfo } from '../../../common/InsightIcon/utils';
import { InsightIcon } from '../../../common/InsightIcon';

Expand All @@ -51,7 +51,6 @@ type SpanDetailProps = {
};

type SpanDetailState = {
hasCodeLocation: boolean;
insights: ISpanInsight[];
};

Expand All @@ -60,7 +59,6 @@ export default class SpanDetail extends React.Component<SpanDetailProps, SpanDet
super(props);
const span = globalState.spans[props.span.spanID];
this.state = {
hasCodeLocation: Boolean(span && span.hasCodeLocation),
insights: span ? span.insights : [],
};
}
Expand All @@ -77,7 +75,6 @@ export default class SpanDetail extends React.Component<SpanDetailProps, SpanDet
updateSpanInfo = (data: unknown) => {
const span = (data as SetSpansDataPayload)[this.props.span.spanID];
this.setState({
hasCodeLocation: Boolean(span && span.hasCodeLocation),
insights: span ? span.insights : [],
});
};
Expand Down Expand Up @@ -137,12 +134,13 @@ export default class SpanDetail extends React.Component<SpanDetailProps, SpanDet
},
];
const deepLinkCopyText = `${window.location.origin}${window.location.pathname}?uiFind=${spanID}`;
const otelLibraryNameTag = this.props.span.tags.find((tag: any) => tag.key === 'otel.library.name');

return (
<div>
<div className="SpanDetail--header">
<div className="ub-flex ub-items-center">
{this.state.hasCodeLocation ? (
{otelLibraryNameTag && this.state.insights.length > 0 ? (
<RouterLink
to="#"
onClick={this.handleGoToCodeLinkClick}
Expand Down