Skip to content

Update codecov #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
james-d-mitchell merged 3 commits into from
Mar 4, 2026
+9 −14
Merged

Update codecov #903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3291c00
CI: Only upload coverage once
Joseph-Edwards Mar 4, 2026
13634d8
CI: Don't fail if coverage too low
Joseph-Edwards Mar 4, 2026
49f1825
CI: Add codecov comment to PRs
Joseph-Edwards Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,11 @@ coverage:
default:
target: 100
threshold: 0
informational: false # Do fail the check if the diff is not 100% covered
informational: true # Don't fail the check if the diff is not 100% covered
changes: # Information about changes in coverage outside the diff
default:
informational: true # Don't fail the check

# Comment to post on PRs
comment: false

ignore:
- "extern/"
- "gap/utils.gi"
Expand Down
11 changes: 4 additions & 7 deletions .github/workflows/os.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ jobs:
pkgs-to-clone: https://github.com/digraphs/graphviz.git https://github.com/gap-packages/NautyTracesInterface.git
pkgs-to-build: io orb datastructures grape profiling NautyTracesInterface


steps:
- uses: actions/checkout@v5
- uses: gap-actions/setup-cygwin@v2
Expand Down Expand Up @@ -93,22 +92,20 @@ jobs:
uses: gap-actions/run-pkg-tests@v4
with:
testfile: tst/github_actions/install.g
coverage: "false"
- name: Run DigraphsTestStandard . . .
uses: gap-actions/run-pkg-tests@v4
with:
testfile: tst/github_actions/standard.g
coverage: "false"
- name: Run DigraphsTestManualExamples . . .
uses: gap-actions/run-pkg-tests@v4
with:
testfile: tst/github_actions/examples.g
coverage: "false"
- name: Run DigraphsTestExtreme . . .
uses: gap-actions/run-pkg-tests@v4
if: ${{ runner.os != 'Windows' }}
with:
testfile: tst/github_actions/extreme.g
- uses: gap-actions/process-coverage@v3
- uses: codecov/codecov-action@v5
with:
token: ${{ secrets.CODECOV_TOKEN }}
# codecov/codecov-action seems unreliable on Windows
fail_ci_if_error: ${{ runner.os != 'Windows' }}
coverage: "false"
7 changes: 4 additions & 3 deletions .github/workflows/ubuntu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ jobs:
pkgs-to-clone: https://github.com/digraphs/graphviz.git https://github.com/gap-packages/NautyTracesInterface.git
pkgs-to-build: io orb datastructures profiling grape NautyTracesInterface

- gap-version: v4.11 # Note: NautyTracesInterface requires GAP 4.12
mode: default # There wouldn't be much point testing GAP v4.11 with only needed packages. The only difference is whether Grape is loaded.
- gap-version: v4.11 # Note: NautyTracesInterface requires GAP 4.12
mode: default # There wouldn't be much point testing GAP v4.11 with only needed packages. The only difference is whether Grape is loaded.
pkgs-to-clone: https://github.com/digraphs/graphviz.git
pkgs-to-build: io* orb* datastructures* profiling* grape*

Expand Down Expand Up @@ -92,7 +92,8 @@ jobs:
testfile: tst/github_actions/extreme.g
mode: ${{ matrix.mode }}
- uses: gap-actions/process-coverage@v3
if: ${{ matrix.gap-version == 'master' && matrix.mode == 'default'}}
- uses: codecov/codecov-action@v5
if: ${{ matrix.gap-version == 'master' && matrix.mode == 'default'}}
with:
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: true
Loading