Cliques coverage#923
Merged
james-d-mitchell merged 3 commits intodigraphs:mainfrom Apr 27, 2026
Merged
Conversation
mtorpey
added
minor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #923 +/- ##
==========================================
+ Coverage 97.38% 97.40% +0.01%
==========================================
Files 50 50
Lines 21193 21193
Branches 639 639
==========================================
+ Hits 20639 20643 +4
+ Misses 489 485 -4
Partials 65 65 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
So kind, @mtorpey |
mo-wilfwilson
approved these changes
Apr 25, 2026
mo-wilfwilson
left a comment
mo-wilfwilson
left a comment
There was a problem hiding this comment.
Looks like a beautiful addition, to me
wilfwilson
approved these changes
Apr 25, 2026
Collaborator
wilfwilson
left a comment
wilfwilson
left a comment
There was a problem hiding this comment.
Whoops, and now I've approved it from my personal account too.
Member
|
Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings cliques.gi to 100% coverage. And it was a nice exercise in understanding the Bron–Kerbosch algorithm and @wilfwilson's excellent 10-year-old implementation of it.
The commits are again logical and distinct, so might want to avoid squashing when merging.