Skip to content

Correct Mutability of LineDigraph#926

Merged
james-d-mitchell merged 1 commit intodigraphs:mainfrom
mtorpey:constructors-coverage
Apr 28, 2026
Merged

Correct Mutability of LineDigraph#926
james-d-mitchell merged 1 commit intodigraphs:mainfrom
mtorpey:constructors-coverage

Conversation

@mtorpey
Copy link
Copy Markdown
Collaborator

@mtorpey mtorpey commented Apr 28, 2026

In 2ffaaae (2019) @wilfwilson modified LineDigraph to output a digraph with the same mutability as the input. This PR updates the documentation to reflect this, and adds a test for it.

This brings constructors.gi code coverage to 100%.

@mtorpey mtorpey added minor A label for PRs or issues that are minor in some sense. doc Issues, bugs, pull requests relating to the documentation bugfix A label for PRs that fix a bug labels Apr 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (5246e0c) to head (8d667a9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #926   +/-   ##
=======================================
  Coverage   97.40%   97.41%           
=======================================
  Files          50       50           
  Lines       21193    21193           
  Branches      639      639           
=======================================
+ Hits        20643    20645    +2     
+ Misses        485      483    -2     
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@james-d-mitchell james-d-mitchell merged commit 783a450 into digraphs:main Apr 28, 2026
31 checks passed
@mtorpey mtorpey deleted the constructors-coverage branch April 28, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix A label for PRs that fix a bug doc Issues, bugs, pull requests relating to the documentation minor A label for PRs or issues that are minor in some sense.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants