Skip to content

add hasDynamicSearch to QueryResponseBean#1476

Merged
shubham1g5 merged 8 commits into
masterfrom
dynamicSearch
Nov 10, 2023
Merged

add hasDynamicSearch to QueryResponseBean#1476
shubham1g5 merged 8 commits into
masterfrom
dynamicSearch

Conversation

@stephherbers
Copy link
Copy Markdown
Contributor

@stephherbers stephherbers commented Oct 16, 2023

Product Description

Formplayer element of this ticket: here

HQ Part one here and Part 2 here

core here

Technical Summary

see this ticket

Safety Assurance

Safety story

No logic change on formplayer, just sends back the variable if a QueryResponse

Automated test coverage

QA Plan

I am not requesting QA

Special deploy instructions

not that I'm aware of, reviews please let me know

  • This PR can be deployed after merge with no further considerations.

Rollback instructions

needs to rollback commcare-core PR and reference PR

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

Copy link
Copy Markdown
Contributor

@shubham1g5 shubham1g5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR needs a test to assert correct dynamic search values based on a suite config. You can probably add it as part of CaseClaimTests

Comment thread src/main/java/org/commcare/formplayer/beans/menus/QueryResponseBean.java Outdated
Comment thread src/main/java/org/commcare/formplayer/session/MenuSession.java Outdated
@shubham1g5 shubham1g5 merged commit aca49e7 into master Nov 10, 2023
@shubham1g5 shubham1g5 deleted the dynamicSearch branch November 10, 2023 15:21
MartinRiese added a commit that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product/feature-flag Change will only affect users who have a specific feature flag enabled

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants