add hasDynamicSearch to QueryResponseBean#1476
Merged
Merged
Conversation
This was referenced Oct 16, 2023
shubham1g5
requested changes
Oct 16, 2023
Contributor
shubham1g5
left a comment
There was a problem hiding this comment.
PR needs a test to assert correct dynamic search values based on a suite config. You can probably add it as part of CaseClaimTests
shubham1g5
requested changes
Nov 8, 2023
shubham1g5
approved these changes
Nov 8, 2023
MartinRiese
added a commit
that referenced
this pull request
May 6, 2026
Essentially rolls back #1476
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product Description
Formplayer element of this ticket: here
HQ Part one here and Part 2 here
core here
Technical Summary
see this ticket
Safety Assurance
Safety story
No logic change on formplayer, just sends back the variable if a QueryResponse
Automated test coverage
QA Plan
I am not requesting QA
Special deploy instructions
not that I'm aware of, reviews please let me know
Rollback instructions
needs to rollback commcare-core PR and reference PR
Review