Pass case search table name as storage cache identifier (USH-6370 fix)#1770
Open
MartinRiese wants to merge 6 commits intomasterfrom
Open
Pass case search table name as storage cache identifier (USH-6370 fix)#1770MartinRiese wants to merge 6 commits intomasterfrom
MartinRiese wants to merge 6 commits intomasterfrom
Conversation
Pass caseSearchTableName to CaseInstanceTreeElement so case search results cache under "casedb:<table_hash>" instead of plain "casedb". Prevents RecordObjectCache key collision with the user's casedb instance when both share a QueryContext during nodeset evaluation. Includes commcare-core submodule bump with the new constructor. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1770 +/- ##
============================================
- Coverage 70.17% 70.10% -0.07%
+ Complexity 2032 2030 -2
============================================
Files 257 257
Lines 8009 8011 +2
Branches 763 764 +1
============================================
- Hits 5620 5616 -4
- Misses 2106 2112 +6
Partials 283 283 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
3 tasks
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Good enough, if it lives in the git history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product Description
Pass caseSearchTableName to CaseInstanceTreeElement so case search results cache under "casedb:<table_hash>" instead of plain "casedb". Prevents RecordObjectCache key collision with the user's casedb instance when both share a QueryContext during nodeset evaluation.
Technical Summary
https://dimagi.atlassian.net/browse/USH-6370
Safety Assurance
Safety story
The change only effects a cache key. The code that populates the cache is unchanged.
The test script to reproduce the issue ran through multiple times without reproduction after this fix was deployed to staging.
Automated test coverage
None
QA Plan
Special deploy instructions
This PR requires these changes in commcare-core
Rollback instructions
Review