feat(calendar): unified calendar view with meetings, milestones, and sprints by dimakis · Pull Request #164 · dimakis/mitzo

dimakis · 2026-04-10T03:51:13Z

Summary

Adds /calendar route with a unified calendar view merging Google Calendar events, release milestones (from Smartsheet via calendar_api.py), and sprint boundaries
Mobile-first design: single-day scrollable view (default) with week toggle; desktop gets a 7-column grid layout
Backend GET /api/calendar endpoint shells out to mgmt/command_center/calendar_api.py with graceful fallback on failure
Click-to-expand event cards showing attendees, milestone feature counts, and video call links

New files

File	Purpose
`server/app.ts` (modified)	`/api/calendar` endpoint + `execFile` async import
`frontend/src/hooks/useCalendarData.ts`	Data fetching hook with date/days params
`frontend/src/pages/CalendarView.tsx`	Page component: EventCard, SprintBar, day grouping, navigation
`frontend/src/styles/global.css` (modified)	Mobile calendar styles (~300 lines)
`frontend/src/styles/desktop.css` (modified)	Desktop 7-column grid overrides
`frontend/src/App.tsx` (modified)	`/calendar` route behind ProtectedRoute

Test plan

5 server tests: auth guard, default params, date/days params, invalid date, days clamping
5 hook tests: fetch on mount, days param, refetch on date change, error handling, type separation
7 page tests: header/nav rendering, meeting cards, milestone cards, sprint bars, loading state, date navigation, back button
Full suite: 827 tests passing
Manual: deploy and verify on phone (day view) and desktop (week grid)

🤖 Generated with Claude Code

dimakis

Centaur Review

Found 8 issue(s) (1 critical) (3 warning).

`server/app.ts`

Calendar feature is well-structured with good test coverage, but the Python script dependency doesn't exist in the repo, and the fetch hook doesn't handle HTTP error responses properly.

🔴 unsafe_assumptions (L675): CALENDAR_SCRIPT references ${BASE_REPO}/command_center/calendar_api.py but this file does not exist in the repository. The route will always fall into the catch branch, returning an error payload. Either the script should be added to the repo, or this dependency should be documented.
🟡 unsafe_assumptions (L694): JSON.parse(stdout) on the Python script output has no validation. Malformed or unexpected output will throw and be caught, but valid JSON with an unexpected shape will be passed straight to the client. Consider validating with a Zod schema (consistent with the project's api-schemas.ts pattern). [fixable]

`frontend/src/hooks/useCalendarData.ts`

Calendar feature is well-structured with good test coverage, but the Python script dependency doesn't exist in the repo, and the fetch hook doesn't handle HTTP error responses properly.

🟡 bugs (L62): The fetch chain calls r.json() without checking r.ok. A 400/401 response will be parsed as JSON and stored in state — the resulting object (e.g. { error: "..." }) has no events or sprints arrays, so the component would render with undefined data. Should check r.ok and reject on error status codes. [fixable]

`frontend/src/pages/tests/CalendarView.test.tsx`

Calendar feature is well-structured with good test coverage, but the Python script dependency doesn't exist in the repo, and the fetch hook doesn't handle HTTP error responses properly.

🔵 missing_tests: No test for the Day/Week view toggle (viewDays state change). The toggle buttons are rendered but never exercised in tests. Also no test for the 'Today' button click (handleToday). [fixable]
🔵 missing_tests: No test for the expanded state of EventCard — clicking a meeting or milestone card should reveal detail section (.cal-event-detail). This is a key interaction path. [fixable]

`frontend/src/pages/CalendarView.tsx`

Calendar feature is well-structured with good test coverage, but the Python script dependency doesn't exist in the repo, and the fetch hook doesn't handle HTTP error responses properly.

🟡 bugs (L155): const today = new Date().toISOString().slice(0, 10) is computed once on render outside of state/effect, but handleToday captures it as a closure. If the component stays mounted across midnight, today becomes stale. Minor in practice, but the same value is also used as initial state for baseDate, which is fine. [fixable]
🔵 style: CalendarView is 256 lines with multiple sub-components (EventCard, SprintBar) and utility functions inlined. Consider extracting EventCard and SprintBar into separate component files to match the project convention of short, focused files. [fixable]

`frontend/src/styles/global.css`

Calendar feature is well-structured with good test coverage, but the Python script dependency doesn't exist in the repo, and the fetch hook doesn't handle HTTP error responses properly.

🔵 style: 308 lines of calendar CSS appended to an already 2700-line global.css. The project has separate style files (e.g. desktop.css). Consider a dedicated calendar.css to keep files manageable. [fixable]

dimakis · 2026-04-10T03:52:51Z

+// --- Calendar API ---
+
+const execFileAsync = promisify(execFile);
+const CALENDAR_SCRIPT = join(BASE_REPO, 'command_center', 'calendar_api.py');


🔴 unsafe_assumptions: CALENDAR_SCRIPT references ${BASE_REPO}/command_center/calendar_api.py but this file does not exist in the repository. The route will always fall into the catch branch, returning an error payload. Either the script should be added to the repo, or this dependency should be documented.

dimakis · 2026-04-10T03:52:51Z

+      [CALENDAR_SCRIPT, '--date', dateParam, '--days', String(daysParam)],
+      { timeout: CALENDAR_TIMEOUT_MS },
+    );
+    const data = JSON.parse(stdout);


🟡 unsafe_assumptions: JSON.parse(stdout) on the Python script output has no validation. Malformed or unexpected output will throw and be caught, but valid JSON with an unexpected shape will be passed straight to the client. Consider validating with a Zod schema (consistent with the project's api-schemas.ts pattern). [fixable]

dimakis · 2026-04-10T03:52:51Z

+
+    fetch(`/api/calendar?date=${date}&days=${days}`)
+      .then((r) => r.json())
+      .then((result: CalendarData) => {


🟡 bugs: The fetch chain calls r.json() without checking r.ok. A 400/401 response will be parsed as JSON and stored in state — the resulting object (e.g. { error: "..." }) has no events or sprints arrays, so the component would render with undefined data. Should check r.ok and reject on error status codes. [fixable]

dimakis · 2026-04-10T03:52:51Z

+      const d = addDays(baseDate, i);
+      map.set(d, []);
+    }
+    for (const evt of events) {


🟡 bugs: const today = new Date().toISOString().slice(0, 10) is computed once on render outside of state/effect, but handleToday captures it as a closure. If the component stays mounted across midnight, today becomes stale. Minor in practice, but the same value is also used as initial state for baseDate, which is fine. [fixable]

dimakis