fix: session restore crash — getMessages returns v2 format, guard stale caches#35
Merged
Conversation
…le caches
The /api/sessions/:id/messages endpoint still returned v1-format objects
({ role, text, toolCalls }) while the v2 frontend expects FinishedMessage
({ messageId, role, blocks: FinishedBlock[] }). Navigating to an existing
session restored shapeless objects — groupBlocks() iterated undefined
blocks, crashing with "undefined is not an object (evaluating 'n')".
Three fixes:
1. Server getMessages() now converts SDK history to v2 FinishedMessage[]
with messageId, role, and blocks array.
2. RESTORE reducer action filters out messages missing messageId/blocks,
so stale v1 localStorage caches degrade gracefully instead of crashing.
3. ChatView invalidates pre-v2 localStorage caches and falls through to
the API. groupBlocks() guards against non-array input.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getMessages()was returning v1-format objects ({ role, text, toolCalls }) while the v2 frontend expectsFinishedMessage({ messageId, role, blocks: FinishedBlock[] }). Navigating to an existing session causedgroupBlocks()to iterateundefined, crashing with "undefined is not an object (evaluating 'n')" in the minified build.messageId/blocks, so stale pre-v2 localStorage caches degrade gracefully.groupBlocks()guards non-array input.Test plan
tsc --noEmitcleanMade with Cursor