fix(protocol): remove ambiguous .m language mapping#364
Merged
Conversation
.m is used by both Objective-C and MATLAB/Octave. Remove the ambiguous mapping so these files return undefined rather than a wrong guess. .mm (Objective-C++) remains — it's unambiguous. Addresses Centaur review finding on PR #357. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dimakis
commented
Jun 2, 2026
Owner
Author
dimakis
left a comment
dimakis
left a comment
There was a problem hiding this comment.
Centaur Review
LGTM — no issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.m → objectivecmapping fromEXT_MAP—.mis ambiguous (Objective-C vs MATLAB/Octave).mm → objectivec(unambiguous Objective-C++).mnow returnsundefined, add explicit.mmtestAddresses Centaur review finding on PR #357.
Test plan
vitest run packages/protocol/__tests__/language.test.ts— 32/32 pass🤖 Generated with Claude Code