Skip to content

Comments

Settings documentation update#23

Merged
dimikot merged 3 commits intodimikot:masterfrom
danieluhl:settings_documentation_update
Aug 19, 2015
Merged

Settings documentation update#23
dimikot merged 3 commits intodimikot:masterfrom
danieluhl:settings_documentation_update

Conversation

@danieluhl
Copy link

Took me 30 mins to find this settings file this morning so I thought I'd save future users the hassle.

@dimikot
Copy link
Owner

dimikot commented Aug 19, 2015

Absolutely. Thanks!

But could you please revert back newlines (\n) trailing all files involved
in the commit? According to Unix best practices, a text file is better to
have a newline character (I saw you've eaten a couple of them) in the end
of the very last line. Why do so best practices exist? E.g. for the
purpose of echo "...">>... or cat a.txt b.txt could work correctly and do
not glue lines. Also, in vim you cannot even save a text file with no
trailing newline.

Then I'll merge the pull request.

On Wednesday, August 19, 2015, Daniel notifications@github.com wrote:

Took me 30 mins to find this settings file this morning so I thought I'd

save future users the hassle.

You can view, comment on, or merge this pull request online at:

#23
Commit Summary

  • added settings info to documentation
  • added back trailing whitespace

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#23.

@danieluhl
Copy link
Author

Ah, good catch. I found the sublimetext3 setting to fix this:
"ensure_newline_at_eof_on_save": true,
"default_line_ending": "unix",

dimikot added a commit that referenced this pull request Aug 19, 2015
@dimikot dimikot merged commit 7604bc8 into dimikot:master Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants