Use docker-compose run in tests, instead of docker-compose up. #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In passing, also change the test build dependencies in a way that docker-compose knows about our usage of the common pagila container. This allows skipping useless builds of that intermediate container. The docker-compose run command also is a better UI for our testing when compared to using docker-compose up and then waiting until the main container stops.
In short docker-compose does not know how to handle build time dependencies between different containers. I suppose we would need a place to push the intermediate images and pull them later, and we're now using the local docker daemon for that by building the pre-requisites manually before invoking the docker-compose build and run commands.
arajkumar
added a commit
to arajkumar/pgcopydb
that referenced
this pull request
Jun 6, 2024
We run vacuumdb on target post initial data copy. It analyzes hypertable and it's chunks, however running analyze on hypertable also analyzes it's chunks leading to double analyze. Solution: Exclude _timescaledb_internal schema from analyze Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
arajkumar
added a commit
to arajkumar/pgcopydb
that referenced
this pull request
Jun 26, 2024
efce882 Problem: Array out of bounds access during transform (dimitri#114) b772480 test: jobs migration created by another user ab53bb8 Problem: double analyze performed on hypertable chunks (dimitri#113) f483439 test: migration of case sensitive objects 98274d3 (chore) Refactor live-migration teardown (dimitri#111) Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
hanefi
added a commit
to hanefi/pgcopydb
that referenced
this pull request
Feb 21, 2025
…unit tests (dimitri#113) * Refactoring: Move `parse_pg_version_string` function to Rust and add unit tests * Update src/bin/lib/pgcopydb-rs/src/ffi/parsing_utils.rs Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com> --------- Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In passing, also change the test build dependencies in a way that docker-compose knows about our usage of the common pagila container. This allows skipping useless builds of that intermediate container.
The docker-compose run command also is a better UI for our testing when compared to using docker-compose up and then waiting until the main container stops.