feat(polish): wire haptics, sounds, and animation into feature views#29
Merged
dinesh-git17 merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
HomeView: settings gear button with sheet presentation, ScrollView wrapper with scroll-transition parallax on cards, reduced-motion awareness. ContractBookView: page-turn sound cue via SoundService on completed page transitions, SoundService environment propagation through UIHostingController bridge. SignaturePadView: medium-impact haptic and signature-placed sound cue on successful sign confirmation. SignatureBlockView: 0.5s ease reveal animation with 0.95-to-1.0 scale transition on signed-image appearance, skipped on initial load to avoid replaying for already-signed content.
CI Health Report
Not triggered: API Sync Contract, Admin Smoke, Backend Quality, DB Schema Check, Dependabot Updates, Push Mock Integration, Release Readiness, iOS Assets & Theme Check, pages-build-deployment 4 passed | 0 failed | 0 other | Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements E8.2: Wire Haptics, Sounds, and Animation Polish. Integrates sound triggers, haptic feedback, and motion polish into four feature views per design doc S6.6, S6.8, and S3.7.
Design Doc Alignment
Changes
scrollTransitionparallax on cards,accessibilityReduceMotionawareness.soundService.play(.pageTurn)indidFinishAnimatingdelegate callback (fires only on completed transitions).UIImpactFeedbackGenerator(style: .medium).impactOccurred()andsoundService.play(.signaturePlaced)at the successful sign-confirmation boundary (afterhasSubmitted = true, beforedismiss())..transition(.opacity.combined(with: .scale(scale: 0.95)))on signature image,withAnimation(.easeInOut(duration: 0.5))on image load for new signings only.hasPerformedInitialLoadflag prevents re-animation on initial view appearance for already-signed content.Risk Surface
scrollTransitiononly activates during actual scroll transitions. On devices where all 3 cards fit on screen, the effect is invisible. Correct behavior -- parallax requires scroll.Testing
xcodebuild -project ExhibitA.xcodeproj -scheme ExhibitA -sdk iphoneos build. Zero errors, zero code warnings.Protocol Zero
./scripts/protocol-zero.shexits 0.Typographic Lint
./scripts/check-em-dashes.shexits 0.