Model and ablation test updates#1
Merged
dingxuan92 merged 1 commit intodingxuan92:ebcl-model-implementationfrom Apr 17, 2026
Merged
Model and ablation test updates#1dingxuan92 merged 1 commit intodingxuan92:ebcl-model-implementationfrom
dingxuan92 merged 1 commit intodingxuan92:ebcl-model-implementationfrom
Conversation
2. Modify the model and unit test add the followings: a. Add more docstring and slightly modify naming and styling for documation and code quality purpose. b. Change the embedding dimension and feedforward dimension to the same as in paper section 4.2 Model Architecture. c. Add Fusion Self-Attention pooling before Linear projection to be the same as in paper section 4.2 Model Architecture. d. Add more more premeter supervised_uses_post to determine if prediction will use pre embedding or pre+post embedding as described in the Finetuning part of Section 3.2
dingxuan92
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a. Add more docstring and slightly modify naming and styling for documation and code quality purpose.
b. Change the embedding dimension and feedforward dimension to the same as in paper section 4.2 Model Architecture.
c. Add Fusion Self-Attention pooling before Linear projection to be the same as in paper section 4.2 Model Architecture.
d. Add more more premeter supervised_uses_post to determine if prediction will use pre embedding or pre+post embedding as described in the Finetuning part of Section 3.2