[cryptography_flutter] Fix platform conditions #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the platform detection mechanism for the cryptography_flutter plugin to simplify the logic and correctly limit support to Android, iOS, and macOS only.
Key changes:
- Replaced conditional imports and asynchronous plugin availability checks with a simpler synchronous approach using
_hasInitializedPluginflag - Removed Linux and Windows platform declarations from
pubspec.yaml - Simplified platform detection to use
defaultTargetPlatforminstead ofdart:io.Platform
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| cryptography_flutter/pubspec.yaml | Removed Linux and Windows platform configurations, limiting plugin to Android, iOS, and macOS |
| cryptography_flutter/lib/src/flutter_cryptography.dart | Refactored plugin presence detection to use _hasInitializedPlugin flag; reordered hmac method |
| cryptography_flutter/lib/src/_internal.dart | Replaced conditional imports with direct platform checks using defaultTargetPlatform; removed async plugin availability check and MissingPluginException handling |
| cryptography_flutter/lib/src/_internal_impl_non_browser.dart | Deleted file (platform detection moved to _internal.dart) |
| cryptography_flutter/lib/src/_internal_impl_browser.dart | Deleted file (platform detection moved to _internal.dart) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
terrier989
force-pushed
the
fix/platforms
branch
from
8a66870 to
0d3cc6c
Compare
terrier989
force-pushed
the
fix/platforms
branch
from
0d3cc6c to
858f5d7
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.