Conversation
akhilles
reviewed
Dec 15, 2025
Contributor
akhilles
left a comment
akhilles
left a comment
There was a problem hiding this comment.
Suggest using https://docs.rs/heck. it has ToSnekCase, ToShoutySnekCase. We already depend on this crate.
| } | ||
|
|
||
| /// Convert a name to UPPERCASE convention. | ||
| pub fn to_uppercase(name: &str) -> String { |
Contributor
Author
There was a problem hiding this comment.
we might want to inject things like promoting ~ to N in the future, so I would rather have this here to do that in our naming conventions
| /// - Cannot end with an underscore | ||
| /// | ||
| /// Examples: `enable_debug`, `num_channels`, `output_voltage` | ||
| pub fn is_snake_case(name: &str) -> bool { |
Contributor
There was a problem hiding this comment.
IMO, simpler to just run to_snake_case and check for equivalence. This way you don't have to keep the two consistent.
| } | ||
|
|
||
| /// Convert a name to snake_case convention. | ||
| pub fn to_snake_case(name: &str) -> String { |
Contributor
There was a problem hiding this comment.
Suggest using https://docs.rs/heck/0.5.0/heck/trait.ToSnekCase.html
akhilles
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add code style advice diagnostics and promote them to warnings in the LSP to enforce a more cohesive coding standard for the models