Prune vendor/ more aggressively, add pcb vendor --all#367
Merged
Conversation
Don't wait for pcb.sum file change. If you accidentally vendor everything, it needs to be cleaned up without requiring a pcb.sum file change.
Make `pcb vendor` only vendor workspace.vendor by default.
akhilles
force-pushed
the
more-pruning
branch
from
c6205a2 to
6456ae7
Compare
LK
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous change only cleaned up vendor dir on
pcb.sumfile change. I don't think this is as intuitive as I assumed. This PR prunes the vendor dir on every vendor and build operation instead.It also changes the
pcb vendordefault behavior to only vendorworkspace.vendormembers.pcb vendor --allvendors everything. I think we have too much muscle memory withpcb vendor, so might be better just make it a safe noop.