clear module cache on LSP save to avoid polluting context#591
Merged
Conversation
LK
approved these changes
Feb 28, 2026
CHANGELOG.md
Outdated
| ### Fixed | ||
|
|
||
| - Normalize net and component symbol source paths to `package://...`, so emitted schematic/netlist `symbol_path` values no longer leak absolute cache paths. | ||
| - Fix LSP simulation diagnostics leaking components across unrelated files due to shared module tree state. |
Contributor
There was a problem hiding this comment.
prob don't need changelog if it was introduced + fixed in same release
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches evaluation-session caching and LSP save/viewer paths; mistakes could lead to stale/incorrect diagnostics or state, though scope is limited to editor workflows.
Overview
Prevents cross-file contamination in the shared evaluation
module_treeby clearing it duringEvalContext::parse_and_analyze_file.Updates the LSP to cache the computed
pcb_sch::Schematic(instead of the fullEvalOutput) immediately after evaluation, and reuses that schematic forviewer/getStateandon_save_diagnostics, clearing the cache on failures and file close.Written by Cursor Bugbot for commit 34b86cb. This will update automatically on new commits. Configure here.