Skip to content

Set required frequency config in Crystal test files#129

Merged
akhilles merged 1 commit intomainfrom
fix/set-frequency
Feb 12, 2026
Merged

Set required frequency config in Crystal test files#129
akhilles merged 1 commit intomainfrom
fix/set-frequency

Conversation

@akhilles
Copy link
Contributor

@akhilles akhilles commented Feb 12, 2026

Note

Low Risk
Small, localized change to generic component parameter configuration and its tests; main risk is compatibility if any callers relied on config_unit parsing behavior.

Overview
Crystal.zen switches frequency (required) and load_capacitance (optional) from config_unit(...) to plain config(...), changing how these unit-typed parameters are parsed/validated.

test_Crystal.zen is updated to explicitly pass frequency="16MHz" when instantiating both 2-pin and 4-pin crystals so the tests continue to generate components with the required parameter set.

Written by Cursor Bugbot for commit cba9d6f. This will update automatically on new commits. Configure here.

@akhilles akhilles requested review from LK and hexdae February 12, 2026 21:22
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@akhilles akhilles merged commit bcb227c into main Feb 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant