fix: guard against null Command.Item value (TypeError on 'in' operator)#407
Open
guuszz wants to merge 2 commits into
Open
fix: guard against null Command.Item value (TypeError on 'in' operator)#407guuszz wants to merge 2 commits into
guuszz wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
<Command.Item value={null}>throwsTypeError: Cannot use 'in' operator to search for 'current' in nullinstead of rendering. Reported in #404.Root cause
In
useValue(cmdk/src/index.tsx), eachpartof the value dependencies is inspected with:When
value={null},partisnull. Becausetypeof null === 'object'(the long-standing JavaScript quirk), the first condition passes and execution reaches'current' in null, which throws — theinoperator requires an object on its right-hand side.Fix
Add a truthiness guard so
null/undefinedshort-circuit before reaching theinoperator:Real refs are truthy objects, so existing behavior is unchanged — only the
null/undefinedcase is now handled gracefully.Fixes #404