Skip to content

Do not create REST endpoints if rest flag is unset #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Do not create REST endpoints if rest flag is unset #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions src/dipdup/hasura.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,6 @@ async def configure(self, reset: bool = False) -> None:

# NOTE: 3. Generate and apply queries and rest endpoints
query_collections_metadata = await self._generate_query_collections_metadata()
query_names = [q['name'] for q in query_collections_metadata]
rest_endpoints_metadata = await self._generate_rest_endpoints_metadata(query_names)

try:
metadata['query_collections'][0]['definition']['queries'] = self._merge_metadata(
# TODO: Separate collection?
Expand All @@ -106,13 +103,21 @@ async def configure(self, reset: bool = False) -> None:
key=lambda m: m['name'],
)
except KeyError:
metadata['query_collections'] = [{"name": "allowed-queries", "definition": {"queries": query_collections_metadata}}]

metadata['rest_endpoints'] = self._merge_metadata(
existing=metadata.get('rest_endpoints', []),
generated=rest_endpoints_metadata,
key=lambda m: m['name'],
)
metadata['query_collections'] = [
{
"name": "allowed-queries",
"definition": {"queries": query_collections_metadata},
}
]

if self._hasura_config.rest:
query_names = [q['name'] for q in query_collections_metadata]
rest_endpoints_metadata = await self._generate_rest_endpoints_metadata(query_names)
metadata['rest_endpoints'] = self._merge_metadata(
existing=metadata.get('rest_endpoints', []),
generated=rest_endpoints_metadata,
key=lambda m: m['name'],
)

await self._replace_metadata(metadata)

Expand Down