Skip to content

feat: add json patches#226

Merged
diranged merged 8 commits intomainfrom
add-json-patches-feat
Jan 23, 2024
Merged

feat: add json patches#226
diranged merged 8 commits intomainfrom
add-json-patches-feat

Conversation

@dnguy078
Copy link
Copy Markdown
Collaborator

@dnguy078 dnguy078 commented Jan 10, 2024

  • Add ability to apply patches to PodSpecs via JSON Patches for PodAccessTemplates

@github-actions github-actions bot added documentation Improvements or additions to documentation go Pull requests that update Go code repo build labels Jan 10, 2024
@dnguy078 dnguy078 changed the title add json patches ability feat: add json patches Jan 10, 2024
@dnguy078 dnguy078 added the enhancement New feature or request label Jan 10, 2024
Repository owner deleted a comment from coveralls Jan 10, 2024
@dnguy078 dnguy078 marked this pull request as ready for review January 10, 2024 22:04
@dnguy078 dnguy078 requested a review from diranged as a code owner January 10, 2024 22:04
Copy link
Copy Markdown
Owner

@diranged diranged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnguy078 This is great... I have a few issues I'd like to resolve in there, but overall its clean, simple and very flexible.

Comment thread internal/api/v1alpha1/pod_spec_mutation_config.go Outdated
Comment thread internal/api/v1alpha1/pod_spec_mutation_config.go Outdated
@diranged
Copy link
Copy Markdown
Owner

@dnguy078 What do you think about https://github.com/diranged/oz/pull/234/files merging into this?

@dnguy078
Copy link
Copy Markdown
Collaborator Author

@dnguy078 What do you think about https://github.com/diranged/oz/pull/234/files merging into this?

Looks good. I’ll need to bump my local go version to 1.21 to fix the go.mod

@dnguy078 dnguy078 requested a review from diranged January 22, 2024 18:35
Copy link
Copy Markdown
Owner

@diranged diranged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for the back and forth!

@diranged diranged merged commit 0e4bc61 into main Jan 23, 2024
@diranged diranged deleted the add-json-patches-feat branch January 23, 2024 14:21
patchSpecOperations:
- op: replace
path: '/spec/containers/0/name'
value: dennis
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants