Skip to content

fix: we were in a reconcile loop because we misunderstood how ctrl.result{} worked#45

Merged
diranged merged 3 commits intomainfrom
fix_loop
Nov 29, 2022
Merged

fix: we were in a reconcile loop because we misunderstood how ctrl.result{} worked#45
diranged merged 3 commits intomainfrom
fix_loop

Conversation

@diranged
Copy link
Copy Markdown
Owner

No description provided.

// Next, get the Pod. If the pod-get fails, then we need to return that failure.
pod := &corev1.Pod{}
err = b.Client.Get(b.Ctx, types.NamespacedName{
err = b.APIReader.Get(b.Ctx, types.NamespacedName{
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to use a non-cached reader of the pod status.

@github-actions github-actions Bot added the github_actions Pull requests that update GitHub Actions code label Nov 29, 2022
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 3570706062

  • 12 of 23 (52.17%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 37.546%

Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/builders/pod_access_builder.go 0 1 0.0%
controllers/exec_access_request_controller.go 0 1 0.0%
controllers/exec_access_template_controller.go 0 3 0.0%
controllers/pod_access_request_controller.go 12 15 80.0%
controllers/pod_access_template_controller.go 0 3 0.0%
Totals Coverage Status
Change from base Build 3570298679: 0.9%
Covered Lines: 618
Relevant Lines: 1646

💛 - Coveralls

@diranged diranged merged commit c1fd6f5 into main Nov 29, 2022
@diranged diranged deleted the fix_loop branch November 29, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build github_actions Pull requests that update GitHub Actions code repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants