Skip to content

fix: execaccessrequest was broken due to bogus test code#55

Merged
diranged merged 2 commits intomainfrom
fix_exec
Dec 5, 2022
Merged

fix: execaccessrequest was broken due to bogus test code#55
diranged merged 2 commits intomainfrom
fix_exec

Conversation

@diranged
Copy link
Copy Markdown
Owner

@diranged diranged commented Dec 5, 2022

while testing some local dev stuff, i broke the execaccessrequest webhook. this was not caught because the contextual defaulter was ignoring the err that was returned.

closes #54

while testing some local dev stuff, i broke the execaccessrequest
webhook. this was not caught because the contextual defaulter was
ignoring the err that was returned.
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 5, 2022

Pull Request Test Coverage Report for Build 3616819404

  • 7 of 9 (77.78%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 44.748%

Changes Missing Coverage Covered Lines Changed/Added Lines %
webhook/contextual_defaulter.go 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
api/v1alpha1/utils.go 4 0%
Totals Coverage Status
Change from base Build 3605176902: -0.2%
Covered Lines: 852
Relevant Lines: 1904

💛 - Coveralls

@diranged diranged merged commit 1edf9d2 into main Dec 5, 2022
@diranged diranged deleted the fix_exec branch December 5, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: remove bogus failure in ExecAccessRequest

2 participants