chore: new request/template specific status interfaces, and a new package for setting conditions#75
Merged
chore: new request/template specific status interfaces, and a new package for setting conditions#75
Conversation
Pull Request Test Coverage Report for Build 3714502747
💛 - Coveralls |
Owner
Author
|
(Ignoring the test coverage numbers dropping... in this case it reflects no actual reduction in testing) |
915b83c to
0dad4b8
Compare
Owner
Author
|
@LaikaN57 Please post-review... I am going to merge this to keep moving forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly code-cleanup in prep for a larger change coming. We create new
IRequestStatusandITemplateStatusinterfaces and move some specific methods into them. We've also moved all of theUpdateCondition()calls to theinternal/controllers/internal/statuspackage - so that the logic is all confined in one place for what types of strings and values are passed into the conditions.