Skip to content

chore: new request/template specific status interfaces, and a new package for setting conditions#75

Merged
diranged merged 3 commits intomainfrom
split_status
Dec 16, 2022
Merged

chore: new request/template specific status interfaces, and a new package for setting conditions#75
diranged merged 3 commits intomainfrom
split_status

Conversation

@diranged
Copy link
Copy Markdown
Owner

This is mostly code-cleanup in prep for a larger change coming. We create new IRequestStatus and ITemplateStatus interfaces and move some specific methods into them. We've also moved all of the UpdateCondition() calls to the internal/controllers/internal/status package - so that the logic is all confined in one place for what types of strings and values are passed into the conditions.

@diranged diranged requested a review from LaikaN57 December 16, 2022 15:38
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 16, 2022

Pull Request Test Coverage Report for Build 3714502747

  • 29 of 184 (15.76%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-5.9%) to 38.272%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/controllers/pod_access_request_controller.go 1 2 50.0%
internal/controllers/exec_access_request_controller.go 0 2 0.0%
internal/controllers/internal/status/set_conditions.go 0 152 0.0%
Files with Coverage Reduction New Missed Lines %
internal/controllers/base_request_controller.go 1 98.39%
Totals Coverage Status
Change from base Build 3713926147: -5.9%
Covered Lines: 762
Relevant Lines: 1991

💛 - Coveralls

@diranged
Copy link
Copy Markdown
Owner Author

(Ignoring the test coverage numbers dropping... in this case it reflects no actual reduction in testing)

@github-actions github-actions bot added documentation Improvements or additions to documentation repo labels Dec 16, 2022
@diranged
Copy link
Copy Markdown
Owner Author

@LaikaN57 Please post-review... I am going to merge this to keep moving forward.

@diranged diranged merged commit d3979fc into main Dec 16, 2022
@diranged diranged deleted the split_status branch December 16, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants