Skip to content

feat: podaccessbuilder satisfying the new IBuilder interface#79

Merged
diranged merged 1 commit intomainfrom
temp
Dec 19, 2022
Merged

feat: podaccessbuilder satisfying the new IBuilder interface#79
diranged merged 1 commit intomainfrom
temp

Conversation

@diranged
Copy link
Copy Markdown
Owner

This piggybacks on #77 and re-implements the PodAccessBuilder in the new IBuilder interface

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 19, 2022

Pull Request Test Coverage Report for Build 3735015948

  • 157 of 231 (67.97%) changed or added relevant lines in 14 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-4.8%) to 44.807%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/v1alpha1/pod_access_request_types.go 0 1 0.0%
internal/builders/podaccessbuilder/access_resources_are_ready.go 77 78 98.72%
internal/builders/utils/create_role.go 0 1 0.0%
internal/builders/utils/create_role_binding.go 0 1 0.0%
internal/controllers/internal/status/update_status.go 2 3 66.67%
internal/builders/podaccessbuilder/get_access_duration.go 0 3 0.0%
internal/builders/utils/object_to_json.go 0 7 0.0%
internal/builders/podaccessbuilder/create_access_resources.go 59 76 77.63%
internal/builders/utils/create_pod.go 0 42 0.0%
Files with Coverage Reduction New Missed Lines %
internal/controllers/requestcontroller/setup_with_manager.go 1 0%
internal/controllers/pod_access_template_controller.go 3 68.18%
Totals Coverage Status
Change from base Build 3733280233: -4.8%
Covered Lines: 893
Relevant Lines: 1993

💛 - Coveralls

@diranged diranged marked this pull request as ready for review December 19, 2022 20:59
@diranged diranged requested a review from LaikaN57 December 19, 2022 20:59
@diranged diranged merged commit 25dfae3 into main Dec 19, 2022
@diranged diranged deleted the temp branch December 19, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants