Skip to content

Remove dark mode divider from user_self_assess.html#547

Merged
AdrianDAlessandro merged 3 commits intodirect-framework:mainfrom
GeoDaoyu:patch-1
Dec 4, 2025
Merged

Remove dark mode divider from user_self_assess.html#547
AdrianDAlessandro merged 3 commits intodirect-framework:mainfrom
GeoDaoyu:patch-1

Conversation

@GeoDaoyu
Copy link
Copy Markdown
Contributor

Removed dark mode divider from user self-assessment page.

Description

Please include a summary of the change and which issue is fixed (if any). Please also
include relevant motivation and context. List any dependencies that are required for
this change.

Fixes #541

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Technical work (non-breaking, change which is work as part of a new feature)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. mkdocs serve)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

Removed dark mode divider from user self-assessment page.
Copy link
Copy Markdown
Collaborator

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution. Looks good so far.

I've noticed that the same divider appears in a few more files. Can you also remove it from them?

As a minimum it is in:

  • main/templates/main/base.account.html
  • main/templates/main/user_self_assess.html
  • main/templates/main/user_skill_profile.html
  • main/templates/main/pages/competencies.html

But it might be in more, so please check.

@GeoDaoyu
Copy link
Copy Markdown
Contributor Author

I searched and fixed it globally.

Copy link
Copy Markdown
Collaborator

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@AdrianDAlessandro AdrianDAlessandro merged commit bb13cea into direct-framework:main Dec 4, 2025
5 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 4, 2025

@all-contributors please add @GeoDaoyu for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors
Copy link
Copy Markdown
Contributor

@github-actions[bot]

I've put up a pull request to add @GeoDaoyu! 🎉

@GeoDaoyu GeoDaoyu deleted the patch-1 branch December 4, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dark mode divider

2 participants