Skip to content

Fix npm version command in README#565

Merged
AdrianDAlessandro merged 2 commits intodirect-framework:mainfrom
cc-a:patch-1
Feb 2, 2026
Merged

Fix npm version command in README#565
AdrianDAlessandro merged 2 commits intodirect-framework:mainfrom
cc-a:patch-1

Conversation

@cc-a
Copy link
Copy Markdown
Contributor

@cc-a cc-a commented Jan 30, 2026

Description

Just noticed whilst running through the README that the previous command npm -v only gives the version of npm this is potentially confusing when the text above is talking about the version of node. npm version is more verbose and provides the node version.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Technical work (non-breaking, change which is work as part of a new feature)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. mkdocs serve)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

Copy link
Copy Markdown
Collaborator

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@AdrianDAlessandro AdrianDAlessandro merged commit 659ce8f into direct-framework:main Feb 2, 2026
4 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2026

@all-contributors please add @cc-a for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors
Copy link
Copy Markdown
Contributor

@github-actions[bot]

We had trouble processing your request. Please try again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants