Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
AdrianDAlessandro
left a comment
There was a problem hiding this comment.
I think the approach to importing should be re-considered. I've made a suggestion, but am open to other approaches.
dalonsoa
approved these changes
Feb 27, 2026
dalonsoa
left a comment
There was a problem hiding this comment.
I'm not a friend of * imports, but it has it use cases, and I think this is one of them, so happy with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I removed the original
views.pyand split the view classes and function into two new filesaccount_views.pyany view relating to the user andpage_views.pythis will store the rest of the generic views.Fixes #544
Type of change
Key checklist
python -m pytest)mkdocs serve)pre-commit run --all-files)Further checks