Skip to content

544 Split Views#610

Merged
AdrianDAlessandro merged 3 commits intomainfrom
544-split-views
Feb 27, 2026
Merged

544 Split Views#610
AdrianDAlessandro merged 3 commits intomainfrom
544-split-views

Conversation

@Sahil590
Copy link
Copy Markdown
Contributor

Description

I removed the original views.py and split the view classes and function into two new files account_views.py any view relating to the user and page_views.py this will store the rest of the generic views.
Fixes #544

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Technical work (non-breaking, change which is work as part of a new feature)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. mkdocs serve)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 98.68421% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
main/views/account_views.py 98.21% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the approach to importing should be re-considered. I've made a suggestion, but am open to other approaches.

Comment thread main/urls.py Outdated
Comment thread main/views/__init__.py Outdated
Copy link
Copy Markdown

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a friend of * imports, but it has it use cases, and I think this is one of them, so happy with this change.

Copy link
Copy Markdown
Collaborator

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@AdrianDAlessandro AdrianDAlessandro merged commit e188448 into main Feb 27, 2026
5 checks passed
@AdrianDAlessandro AdrianDAlessandro deleted the 544-split-views branch February 27, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split views module into multiple files

3 participants