Skip to content

remove the read from the json file and use the models to populate the…#619

Merged
AdrianDAlessandro merged 17 commits intomainfrom
546-competencies-page
Mar 13, 2026
Merged

remove the read from the json file and use the models to populate the…#619
AdrianDAlessandro merged 17 commits intomainfrom
546-competencies-page

Conversation

@Sahil590
Copy link
Copy Markdown
Contributor

@Sahil590 Sahil590 commented Mar 3, 2026

… competencies page

Description

Please include a summary of the change and which issue is fixed (if any). Please also
include relevant motivation and context. List any dependencies that are required for
this change.

Fixes #546

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Technical work (non-breaking, change which is work as part of a new feature)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. mkdocs serve)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, overall really good. I've just got a few nit-picky changes suggested below.

Comment thread main/views/page_views.py Outdated
Comment thread main/views/page_views.py Outdated
Comment thread main/templates/main/pages/competencies.html Outdated
Comment thread main/views/page_views.py Outdated
Comment thread main/views/page_views.py Outdated
Copy link
Copy Markdown

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Collaborator

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more small changes

Comment thread main/templates/main/pages/competencies.html Outdated
Comment thread main/templates/main/pages/competencies.html Outdated
Comment thread main/templates/main/pages/competencies.html Outdated
Comment thread main/templates/main/pages/competencies.html Outdated
Comment thread tests/main/test_main_views.py
Sahil590 and others added 3 commits March 13, 2026 09:23
Co-authored-by: Adrian D'Alessandro <a.dalessandro@imperial.ac.uk>
Co-authored-by: Adrian D'Alessandro <a.dalessandro@imperial.ac.uk>
Co-authored-by: Adrian D'Alessandro <a.dalessandro@imperial.ac.uk>
@Sahil590 Sahil590 force-pushed the 546-competencies-page branch from df497ec to 921b73d Compare March 13, 2026 13:30
Copy link
Copy Markdown
Collaborator

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, happy with all of this! I have one nit-pick about the urls, but after that I'm happy!

Comment thread main/templates/main/pages/competencies.html Outdated
Comment thread main/templates/main/pages/competencies.html Outdated
Comment thread main/templates/main/pages/competencies.html Outdated
Comment thread main/templates/main/pages/competencies.html Outdated
AdrianDAlessandro and others added 2 commits March 13, 2026 16:27
Co-authored-by: Adrian D'Alessandro <a.dalessandro@imperial.ac.uk>
@AdrianDAlessandro AdrianDAlessandro merged commit deabb1c into main Mar 13, 2026
4 checks passed
@AdrianDAlessandro AdrianDAlessandro deleted the 546-competencies-page branch March 13, 2026 16:29
@github-actions
Copy link
Copy Markdown
Contributor

@all-contributors please add @Sahil590 for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors
Copy link
Copy Markdown
Contributor

@github-actions[bot]

I've put up a pull request to add @Sahil590! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use the database to build the Competencies Page

3 participants