remove the read from the json file and use the models to populate the…#619
remove the read from the json file and use the models to populate the…#619AdrianDAlessandro merged 17 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
AdrianDAlessandro
left a comment
There was a problem hiding this comment.
Again, overall really good. I've just got a few nit-picky changes suggested below.
AdrianDAlessandro
left a comment
There was a problem hiding this comment.
Just a couple more small changes
Co-authored-by: Adrian D'Alessandro <a.dalessandro@imperial.ac.uk>
Co-authored-by: Adrian D'Alessandro <a.dalessandro@imperial.ac.uk>
Co-authored-by: Adrian D'Alessandro <a.dalessandro@imperial.ac.uk>
df497ec to
921b73d
Compare
AdrianDAlessandro
left a comment
There was a problem hiding this comment.
Excellent, happy with all of this! I have one nit-pick about the urls, but after that I'm happy!
Co-authored-by: Adrian D'Alessandro <a.dalessandro@imperial.ac.uk>
for more information, see https://pre-commit.ci
|
@all-contributors please add @Sahil590 for code.
|
|
@github-actions[bot] I've put up a pull request to add @Sahil590! 🎉 |
… competencies page
Description
Please include a summary of the change and which issue is fixed (if any). Please also
include relevant motivation and context. List any dependencies that are required for
this change.
Fixes #546
Type of change
Key checklist
python -m pytest)mkdocs serve)pre-commit run --all-files)Further checks