Skip to content

Include templates for standard error pages#652

Merged
AdrianDAlessandro merged 2 commits intomainfrom
error-pages
Mar 26, 2026
Merged

Include templates for standard error pages#652
AdrianDAlessandro merged 2 commits intomainfrom
error-pages

Conversation

@AdrianDAlessandro
Copy link
Copy Markdown
Collaborator

Description

This PR adds the standard error pages that Django provides views for.

@davehorsfall I looked at the options in the Around template, and I didn't like them as much because they didn't include a navbar and footer, which I think are nice to keep. I also wasn't really able to make them work well with the navbar and footer. So I kept these quite simple. If you have a better approach, feel free to suggest changes, or change them later.

Fixes #640

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Technical work (non-breaking, change which is work as part of a new feature)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. mkdocs serve)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@Sahil590 Sahil590 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected. LGTM

@AdrianDAlessandro AdrianDAlessandro merged commit 664146c into main Mar 26, 2026
5 checks passed
@AdrianDAlessandro AdrianDAlessandro deleted the error-pages branch March 26, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create custom error pages

2 participants