Skip to content

enforce class based views to rest of the views#655

Merged
Sahil590 merged 4 commits intomainfrom
596-class-views
Mar 26, 2026
Merged

enforce class based views to rest of the views#655
Sahil590 merged 4 commits intomainfrom
596-class-views

Conversation

@Sahil590
Copy link
Copy Markdown
Contributor

@Sahil590 Sahil590 commented Mar 26, 2026

Description

I have changes the following views to class based views:

  • Index
  • Privacy
  • Account_overview
  • Skills

Fixes #596

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Technical work (non-breaking, change which is work as part of a new feature)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. mkdocs serve)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
main/views/page_views.py 95.65% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Happy with this. One small suggestion and a question. But feel free to merge after they're dealt with

Comment thread main/views/account_views.py Outdated
Comment thread main/views/page_views.py Outdated
Sahil590 and others added 3 commits March 26, 2026 13:48
Co-authored-by: Adrian D'Alessandro <a.dalessandro@imperial.ac.uk>
@Sahil590 Sahil590 merged commit ff3a247 into main Mar 26, 2026
5 checks passed
@Sahil590 Sahil590 deleted the 596-class-views branch March 26, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update views to use class-based views

2 participants