Skip to content

Fix skill wheel not building bug#658

Merged
AdrianDAlessandro merged 1 commit intomainfrom
fix-skill-profile
Mar 27, 2026
Merged

Fix skill wheel not building bug#658
AdrianDAlessandro merged 1 commit intomainfrom
fix-skill-profile

Conversation

@AdrianDAlessandro
Copy link
Copy Markdown
Collaborator

Description

This is a temporary fix to make sure the skill wheel is displayed in a user's profile. The longer-term fix requires a big refactor of the JS code that builds the skill wheel, but that will take too long. I've included a test for what I can. Unfortunately, we can't test the result of the the script building the plot, only what was sent to it.

Fixes #656
Fixes #465

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Technical work (non-breaking, change which is work as part of a new feature)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. mkdocs serve)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@Sahil590 Sahil590 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdrianDAlessandro AdrianDAlessandro merged commit f2eea90 into main Mar 27, 2026
5 checks passed
@AdrianDAlessandro AdrianDAlessandro deleted the fix-skill-profile branch March 27, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skill profile page does not display a skill wheel Backend amends for skills view

2 participants