Clean up get_context_data for views that plot a skill wheel#662
Merged
AdrianDAlessandro merged 2 commits intomainfrom Mar 31, 2026
Merged
Clean up get_context_data for views that plot a skill wheel#662AdrianDAlessandro merged 2 commits intomainfrom
AdrianDAlessandro merged 2 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sahil590
approved these changes
Mar 31, 2026
Contributor
Sahil590
left a comment
Sahil590
left a comment
There was a problem hiding this comment.
LGTM had a comment below not to sure about. Overall there are no breaking changes so can approve.
Comment on lines
+50
to
+52
| context["sample_data"] = _extract_and_combine_roles( | ||
| ["main/static/assets/sample_data/sample_profile_1.json"] | ||
| ) |
Contributor
There was a problem hiding this comment.
Wouldn't this need to be a JSON string?
Collaborator
Author
There was a problem hiding this comment.
No, it doesn't seem to work when it's a JSON string. I think the Django templating stuff need them to be python objects to deserialise properly.
AdrianDAlessandro
force-pushed
the
plot-views
branch
from
58224e0 to
1ae2d17
Compare
github-project-automation
Bot
moved this from 📋 Backlog
to ✅ Done
in Web App Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just a couple of code tidy-ups from while I was looking into #661
Type of change
Key checklist
python -m pytest)mkdocs serve)pre-commit run --all-files)Further checks