Skip to content

Add a rank field to the Competency and Skill models#667

Merged
AdrianDAlessandro merged 3 commits intomainfrom
rank-models
Apr 1, 2026
Merged

Add a rank field to the Competency and Skill models#667
AdrianDAlessandro merged 3 commits intomainfrom
rank-models

Conversation

@AdrianDAlessandro
Copy link
Copy Markdown
Collaborator

Description

This PR adds a rank field to the Competency and Skill models so they can have a default ordering that matches the one intended. The newest framework has this in it, so we need this before the next release.

Fixes #657

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Technical work (non-breaking, change which is work as part of a new feature)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. mkdocs serve)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@Sahil590 Sahil590 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdrianDAlessandro AdrianDAlessandro merged commit 584045a into main Apr 1, 2026
5 checks passed
@AdrianDAlessandro AdrianDAlessandro deleted the rank-models branch April 1, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a rank field to Skill and Competency models

2 participants