Include terms and conditions agreement checkbox in registration#677
Merged
AdrianDAlessandro merged 2 commits intomainfrom Apr 13, 2026
Merged
Include terms and conditions agreement checkbox in registration#677AdrianDAlessandro merged 2 commits intomainfrom
AdrianDAlessandro merged 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
11 tasks
davehorsfall
requested changes
Apr 10, 2026
Collaborator
davehorsfall
left a comment
There was a problem hiding this comment.
This is all working for me. I've just left some minor accessibility comments to address. Happy to approve after that.
| self.fields["tos"].label = _( | ||
| format_html( | ||
| 'I have read and agree to the <a href="{}">Terms and Conditions</a> and' | ||
| ' <a href="{}">Privacy Policy</a>.', |
Collaborator
There was a problem hiding this comment.
Consider adding following to both tags to improve accessibility:
target="_blank" rel="noopener noreferrer"
18bdd12 to
2b71b1a
Compare
2b71b1a to
025deba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a checkbox to the registration form that must be checked for users to register. This checkbox is to agree to the pre-existing privacy policy and terms and conditions.
It also saves this with a corresponding timestamp in the database along with the user. So we know when they registered and when they checked the acceptance box.
Fixes #669
Type of change
Key checklist
python -m pytest)mkdocs serve)pre-commit run --all-files)Further checks