Skip to content

Learning resources page#689

Merged
AdrianDAlessandro merged 8 commits intomainfrom
learning-resources-page
Apr 16, 2026
Merged

Learning resources page#689
AdrianDAlessandro merged 8 commits intomainfrom
learning-resources-page

Conversation

@AdrianDAlessandro
Copy link
Copy Markdown
Collaborator

Description

This PR adds a table of learning resources to the learning resources page. It looks like this

Screenshot 2026-04-15 at 17 27 31

Fixes #670

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Technical work (non-breaking, change which is work as part of a new feature)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. mkdocs serve)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@Sahil590 Sahil590 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@PhilReedData
Copy link
Copy Markdown
Contributor

Nice work. I would change the column heading from 'Related skills' to 'Relevant skills' or similar, since 'Related skills' as a label is already used when one skill points to another skill.

Copy link
Copy Markdown
Contributor

@anenadic anenadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @AdrianDAlessandro - thank you

@anenadic
Copy link
Copy Markdown
Contributor

Nice work. I would change the column heading from 'Related skills' to 'Relevant skills' or similar, since 'Related skills' as a label is already used when one skill points to another skill.

Agree with @PhilReedData - "relevant skills" would be great. OR just "skills" if you want to keep the table headings to a single word.

Copy link
Copy Markdown
Contributor

@PhilReedData PhilReedData left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't got a test environment but I think this is the right way to rename the column as suggested.

Comment thread main/tables.py Outdated
Comment thread main/tables.py Outdated
Comment thread tests/main/test_main_views.py Outdated
@AdrianDAlessandro AdrianDAlessandro force-pushed the learning-resources-page branch from 9405b82 to 824d7f1 Compare April 16, 2026 13:27
@AdrianDAlessandro AdrianDAlessandro dismissed PhilReedData’s stale review April 16, 2026 13:45

Made the change in-meeting

@AdrianDAlessandro AdrianDAlessandro force-pushed the learning-resources-page branch from 824d7f1 to 66d2bcb Compare April 16, 2026 13:45
@AdrianDAlessandro AdrianDAlessandro force-pushed the learning-resources-page branch from 66d2bcb to be667a0 Compare April 16, 2026 13:48
@AdrianDAlessandro AdrianDAlessandro merged commit 0fd622d into main Apr 16, 2026
5 checks passed
@AdrianDAlessandro AdrianDAlessandro deleted the learning-resources-page branch April 16, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Learning Resources page

4 participants