Skip to content

Fix banner visibility #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexchopin merged 1 commit into from
Nov 27, 2025
Merged

Fix banner visibility #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions app/components/DocsBanner.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,29 +6,38 @@ const dismissedBanners = useCookie('directus-dismissed-banners', {
});

const bannerVisible = computed(() => {
if (!unref(banner)) return false;
return unref(dismissedBanners).includes(unref(banner)!.id) === false;
const bannerValue = unref(banner);
if (!bannerValue) return false;
if (Object.keys(bannerValue).length === 0) return false;

if (!('id' in bannerValue) || !('content' in bannerValue)) return false;
return unref(dismissedBanners).includes(bannerValue.id) === false;
});

const dismiss = (id: string) => {
dismissedBanners.value = [...unref(dismissedBanners), id];
};

const iconName = computed(() => {
if (!unref(banner)) return null;
return getIconName(unref(banner)!.icon);
const bannerValue = unref(banner);
if (
!bannerValue
|| (typeof bannerValue === 'object' && Object.keys(bannerValue).length === 0)
)
return null;
return getIconName(bannerValue.icon);
});
</script>

<template>
<div
v-if="banner && bannerVisible"
class="bg-inverted text-inverted cursor-pointer h-8"
class="bg-inverted text-inverted cursor-pointer h-8"
>
<UContainer class="h-full flex items-center gap-x-4">
<NuxtLink
class="flex-grow h-full flex items-center text-background no-underline text-xs leading-xs font-semibold group"
:href="banner.link ?? undefined"
:href="banner?.link ?? undefined"
>
<Icon
v-if="iconName"
Expand All @@ -37,7 +46,7 @@ const iconName = computed(() => {
/>
<span
class="whitespace-nowrap overflow-hidden text-ellipsis"
v-html="banner.content"
v-html="banner?.content"
/>
<Icon
class="hidden md:block transform duration-150 ease-out ml-1 group-hover:translate-x-1 size-5"
Expand All @@ -49,7 +58,7 @@ const iconName = computed(() => {
aria-label="Close"
:padded="false"
icon="material-symbols:close"
@click="dismiss(banner.id)"
@click="banner && dismiss(banner.id)"
>
<Icon
name="material-symbols:close"
Expand Down
6 changes: 3 additions & 3 deletions server/api/banner.get.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ export default defineCachedEventHandler(async () => {
limit: 1,
}));

if (!data) return {};
if (!data) return null;

return data;
}
catch (error) {
console.error(error);
return {};
console.error('Banner API error:', error);
return null;
}
}, {
maxAge: 60 * 5, // 5 minutes
Expand Down