fix: guard pixelsToPercentage against zero area#70
Merged
Conversation
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a guard to prevent division by zero in the pixelsToPercentage utility function. The fix prevents NaN or Infinity values from being returned during component mount when the container area is 0 (before measurement occurs).
Changes:
- Added zero-area guard to
pixelsToPercentagefunction to return 0 instead ofNaN/Infinity - Added comprehensive test coverage for the edge case
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/vue-split-panel/src/utils/pixels-to-percentage.ts | Added ternary guard to return 0 when area is 0, preventing division by zero |
| packages/vue-split-panel/src/utils/pixels-to-percentage.test.ts | Added test cases for zero area scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rijkvanzanten
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returns 0 when area is 0 instead of
NaN/Infinity. This prevents invalid values during component mount before the container has been measured.